Skip to content

chore(test): replaced httpmock by (already used) wiremock#3342

Open
vbar wants to merge 4 commits intomainfrom
vbar/httpmock-to-wiremock
Open

chore(test): replaced httpmock by (already used) wiremock#3342
vbar wants to merge 4 commits intomainfrom
vbar/httpmock-to-wiremock

Conversation

@vbar
Copy link
Copy Markdown
Contributor

@vbar vbar commented Apr 15, 2026

Also removed crate gateway-test-utils (with its usage replaced by wiremock).

Closes #3325.

@vbar vbar requested a review from a team as a code owner April 15, 2026 10:39
Comment thread crates/gateway-client/Cargo.toml Outdated
@vbar vbar force-pushed the vbar/httpmock-to-wiremock branch from 7921567 to 6a1e0d9 Compare April 16, 2026 14:11
@vbar vbar marked this pull request as draft April 16, 2026 14:11
Comment thread crates/gateway-types/src/error.rs Outdated
Copy link
Copy Markdown
Contributor

@CHr15F0x CHr15F0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % (the docs nit && gateway-test-utils source should be git-rm'ed from the source tree).

@vbar
Copy link
Copy Markdown
Contributor Author

vbar commented Apr 16, 2026

gateway-test-utils source should be git-rm'ed from the source tree

Yes, once it's replaced in pathfinder-rpc... :-)

@CHr15F0x
Copy link
Copy Markdown
Contributor

gateway-test-utils source should be git-rm'ed from the source tree

Yes, once it's replaced in pathfinder-rpc... :-)

gateway-test-utils source should be git-rm'ed from the source tree

Yes, once it's replaced in pathfinder-rpc... :-)

Sorry! I rushed on a still-a-draft PR.

@vbar vbar force-pushed the vbar/httpmock-to-wiremock branch from d390fe9 to ffbee3a Compare April 17, 2026 08:29
@vbar vbar marked this pull request as ready for review April 17, 2026 08:32
@vbar
Copy link
Copy Markdown
Contributor Author

vbar commented Apr 17, 2026

gateway-test-utils source should be git-rm'ed from the source tree

Yes, once it's replaced in pathfinder-rpc... :-)

Sorry! I rushed on a still-a-draft PR.

OK, now it's ready.

@vbar vbar requested a review from CHr15F0x April 17, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove gateway_test_utils and httmock in favor of wiremock

2 participants